DataDog: Check for response object before returning the generic error #4259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
zroubalik
requested changes
Feb 21, 2023
CHANGELOG.md
Outdated
| @@ -82,6 +82,7 @@ Here is an overview of all new **experimental** features: | |||
| - **Kafka Scaler**: Support 0 in activationLagThreshold configuration ([#4137](https://github.com/kedacore/keda/issues/4137)) | |||
| - **Prometheus Metrics**: Expose Prometheus Metrics also when getting ScaledObject state ([#4075](https://github.com/kedacore/keda/issues/4075)) | |||
| - **Redis Scalers**: Fix panic produced by incorrect logger initialization ([#4197](https://github.com/kedacore/keda/issues/4197)) | |||
| - **Datadog Scaler**: Return correct error when getting a 429 error ([#4187](https://github.com/kedacore/keda/issues/4187)) | |||
There was a problem hiding this comment.
just a nit, could you please sort this alphabetically?
|
/run-e2e datadog* |
zroubalik
changed the title
zroubalik
approved these changes
Feb 22, 2023
|
Thanks for the fix @arapulido ! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Datadog API now creates a generic error object when returning a 429.
This fix checks the response object before the error object to craft a more complete error when reaching too many requests.
Checklist
- [ ] When introducing a new scaler, I agree with the scaling governance policy- [ ] I have verified that my change is according to the deprecations & breaking changes policy- [ ] Tests have been added- [ ] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)- [ ] A PR is opened to update the documentation on (repo) (if applicable)Fixes #4187